feat: add isEqualCaseInsensitive() to @metamask/controller-utils
#4811
+49
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiexi
commented
Oct 17, 2024
| * @param value2 - first string to compare | ||
| * @returns true if 2 strings are identical when they are lowercase | ||
| */ | ||
| export function isEqualCaseInsensitive( |
There was a problem hiding this comment.
Note, this is not exported outside of the assets-controller package, and therefore does not require a changelog item
This was referenced Oct 17, 2024
Gudahtt
reviewed
Oct 17, 2024
Gudahtt
previously approved these changes
Oct 18, 2024
Co-authored-by: Mark Stacey <[email protected]>
adonesky1
force-pushed
the
controller-utils-isEqualCaseInsensitive
branch
from
109a7bf to
3c43fce
Compare
adonesky1
approved these changes
Oct 18, 2024
mikesposito
approved these changes
Oct 21, 2024
adonesky1
added a commit
that referenced
this pull request
Oct 21, 2024
## Explanation Creates the initial (empty) `@metamask/multichain` package to make downstream additions to this package easier to review. ## References Upstream: #4811 Downstream: #4784 ## Changelog ### `@metamask/multichain` - **ADDED**: Initial skeleton package for `@metamask/multichain` ## Checklist - [X] I've updated the test suite for new or updated code as appropriate - [X] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [X] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [X] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes --------- Co-authored-by: Mark Stacey <[email protected]> Co-authored-by: Alex <[email protected]>
Merged
bergeron
added a commit
that referenced
this pull request
Oct 23, 2024
Release of controller utils package to include #4811 --------- Co-authored-by: cryptodev-2s <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Moves
isEqualCaseInsensitive()from assets-controllers into controller-utils because it will be used elsewhere downstreamReferences
Upstream: None. This is the start.
Downstream: #4812
Changelog
@metamask/controller-utilsisEqualCaseInsensitive()helper which performs case insensitive comparison against two strings and returns true if they are equivalent.Checklist